Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAMC System (incl banners): adopt V1 and V3 components where components are not used #16952

Closed
8 tasks done
laflannery opened this issue Jan 22, 2024 · 5 comments
Closed
8 tasks done
Assignees
Labels
accessibility Issues related to accessibility CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area va-icon VAMC CMS managed product owned by Facilities team

Comments

@laflannery
Copy link
Contributor

laflannery commented Jan 22, 2024

Description

VAMC System pages need the following updates to components:

Example pages:

List of Components

Elements that are not using components that should be (Backlog)

  1. Link
  2. Telephone
    • These are currently not using a component at all but they should be using aria-describedby v1 component
    • Exts should be parsed correctly in the component
  3. Back to top component
    • Update 5/3: After determining that this component does not actually have built in intelligence to only show based on page height:
      • This should still be added, the System pages are typically longer so having this on these pages will probably make sense more often than not.
  4. Banner
    • The banners are not using any component but should be updated to use the v1 component
    • Note regarding implementation: VBA already uses the component and has it's own file. I don't know if it would be useful/efficient/possible to have VAMCs and VBAs use one file so if thee ever needed to be updated again it would only be in 1 place rather than 2?
    • At the time of writing this, Durham as 2 banners for testing but who knows if they will be there later
      Screenshot 2024-03-13 at 3 18 13 PM
  5. Related Links/Spotlight
    • There is a list of links that we are going to change to align with the DS. This is going to use Related Links. Based on Storybook, I don't believe there is standard component markup for this (i.e. <va-XXX>) Here is the annotated Figma design for what this will look like:
      Screenshot 2024-03-22 at 1 54 08 PM

Acceptance Criteria

  • Link component has been added
  • Back to top component has been added
  • Banner component has been added
  • Related Links have been added
  • Update and run existing test(s).
  • If additional tests are needed, stub a ticket to note this for future work.
  • Requires accessibility review
  • Change managemen for Related links
@laflannery laflannery added the Needs refining Issue status label Jan 22, 2024
@laflannery laflannery changed the title Update VAMC product with components Update VAMC System template with components Jan 22, 2024
@laflannery laflannery added VAMC CMS managed product owned by Facilities team VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) accessibility Issues related to accessibility labels Jan 24, 2024
@maxx1128
Copy link

I estimate this ticket at a 3 for moving a good amount of relatively simple elements over to components (need I even say it again?)

@xiongjaneg xiongjaneg removed the Needs refining Issue status label Feb 28, 2024
@jilladams jilladams changed the title Update VAMC System template with components Update VAMC System template with V1 components Mar 27, 2024
@jilladams jilladams changed the title Update VAMC System template with V1 components VAMC System: adopt V1 and V3 components where components are not used Mar 27, 2024
@laflannery
Copy link
Contributor Author

I added an AC for change management for Related links - I spoke to @mmiddaugh and since there is a large-ish display change with the Related links update she felt that giving folks a heads up that this was happening would be good.

@laflannery
Copy link
Contributor Author

Telephone moved to #16148

@davidmpickett davidmpickett added the CY24-Q2 Calendar year Q2 2024 priority label Apr 11, 2024
@jilladams jilladams changed the title VAMC System: adopt V1 and V3 components where components are not used VAMC System (incl banners): adopt V1 and V3 components where components are not used Apr 17, 2024
@jilladams jilladams added the Needs refining Issue status label Apr 17, 2024
@jilladams jilladams removed the Needs refining Issue status label Apr 23, 2024
@jilladams
Copy link
Contributor

Custom banners on this page may or may not be weird in the Typography update. (Was weird, then branch updated, now is not weird.) In any case, we need to adopt the component and that's how we'll plan to fix the weird padding, if it stays weird in prod.
https://app.mural.co/t/departmentofveteransaffairs9999/m/departmentofveteransaffairs9999/1715017468641/ffb7fbb561bbca436ad535ecbbf0b96815413c29?wid=0-1715017487021&sender=u0b235d03cbd64f7f93673243

@laflannery laflannery added the Public Websites Scrum team in the Sitewide crew label May 15, 2024
@randimays
Copy link
Contributor

Jill sent out change management on 5/22. Slack thread here: https://dsva.slack.com/archives/C06NMUK12LR/p1716323803156549

Successfully validated in production. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area va-icon VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

6 participants