Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/websocket): Fix close code without reason #27578

Merged

Conversation

littledivy
Copy link
Member

Fixes #27566

The close code wasn't sent if reason was None, defaulting to 1005. This patch allows sending close code without reason.

The close code wasn't sent if reason was None, defaulting to 1005. This patch allows sending close code without reason.
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit e233173 into denoland:main Jan 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSocket close code always 1005
2 participants