Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support URL Image Sources and Private Registries (esp. AWS ECR) #82

Open
RobertFischer opened this issue Apr 24, 2021 · 0 comments · May be fixed by #83
Open

Support URL Image Sources and Private Registries (esp. AWS ECR) #82

RobertFischer opened this issue Apr 24, 2021 · 0 comments · May be fixed by #83

Comments

@RobertFischer
Copy link

There's a TODO in the Haddocks on pullImage: https://hackage.haskell.org/package/docker-0.6.0.5/docs/Docker-Client-Api.html#v:pullImage I'd like to take a swing at the second of those, and then the first. Any thoughts/suggestions/recommendations/requirements on the implementation?

@RobertFischer RobertFischer changed the title Support Private Registries (esp. AWS ECR) Support URL Image Sources and Private Registries (esp. AWS ECR) Apr 24, 2021
mrBliss added a commit to mrBliss/docker-hs that referenced this issue Aug 6, 2021
Fixes denibertovic#82.

`pullImage` now takes a `PullOpts` argument, which includes an optional
`AuthConfig`. For more details, see:
https://docs.docker.com/engine/api/v1.41/#section/Authentication
@mrBliss mrBliss linked a pull request Aug 6, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant