Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultHttpHandler and unixHttpHandler use ResponseTimeoutDefault #78

Open
mbg opened this issue Apr 6, 2020 · 0 comments
Open

defaultHttpHandler and unixHttpHandler use ResponseTimeoutDefault #78

mbg opened this issue Apr 6, 2020 · 0 comments

Comments

@mbg
Copy link
Contributor

mbg commented Apr 6, 2020

Both defaultHttpHandler and unixHttpHandler use defaultManagerSettings for which responseTimeout = ResponseTimeoutDefault. This just came to bite me when I used the waitContainer API with a non-trivial container task. It seems that the /wait API does not send a response until the container has stopped, so using ResponseTimeoutDefault does not make much sense here. I am wondering whether:

  • It would make sense to document this and add a suitable warning to the documentation for waitContainer?
  • Modifying the request made in waitContainer to override the responseTimeout to set it to ResponseTimeoutNone?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant