From 230f25a78cca1285a0b37dc7cd5c2a9665c62ba9 Mon Sep 17 00:00:00 2001 From: Dimitris Efstathiou Date: Thu, 19 Dec 2024 14:50:22 +0200 Subject: [PATCH] pkp/pkp-lib#10630 Review Fixes --- .../invitation/core/InvitationActionRedirectController.php | 4 ++++ .../handlers/UserRoleAssignmentInviteRedirectController.php | 3 +++ .../resources/UserRoleAssignmentInviteManagerDataResource.php | 1 - 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/classes/invitation/core/InvitationActionRedirectController.php b/classes/invitation/core/InvitationActionRedirectController.php index c3975bffb10..70fbf842f86 100644 --- a/classes/invitation/core/InvitationActionRedirectController.php +++ b/classes/invitation/core/InvitationActionRedirectController.php @@ -18,8 +18,12 @@ use Illuminate\Routing\Controller; use PKP\invitation\core\enums\InvitationAction; +/** + * @template TInvitation of Invitation + */ abstract class InvitationActionRedirectController extends Controller { + /** @var TInvitation */ protected Invitation $invitation; public function __construct(Invitation $invitation) diff --git a/classes/invitation/invitations/userRoleAssignment/handlers/UserRoleAssignmentInviteRedirectController.php b/classes/invitation/invitations/userRoleAssignment/handlers/UserRoleAssignmentInviteRedirectController.php index 1cfa72210cd..b03e4186424 100644 --- a/classes/invitation/invitations/userRoleAssignment/handlers/UserRoleAssignmentInviteRedirectController.php +++ b/classes/invitation/invitations/userRoleAssignment/handlers/UserRoleAssignmentInviteRedirectController.php @@ -23,6 +23,9 @@ use PKP\invitation\stepTypes\AcceptInvitationStep; use APP\facades\Repo; +/** + * @extends InvitationActionRedirectController + */ class UserRoleAssignmentInviteRedirectController extends InvitationActionRedirectController { public function getInvitation(): UserRoleAssignmentInvite diff --git a/classes/invitation/invitations/userRoleAssignment/resources/UserRoleAssignmentInviteManagerDataResource.php b/classes/invitation/invitations/userRoleAssignment/resources/UserRoleAssignmentInviteManagerDataResource.php index a467ea3d3b6..d846d393819 100644 --- a/classes/invitation/invitations/userRoleAssignment/resources/UserRoleAssignmentInviteManagerDataResource.php +++ b/classes/invitation/invitations/userRoleAssignment/resources/UserRoleAssignmentInviteManagerDataResource.php @@ -16,7 +16,6 @@ use Illuminate\Http\Request; use PKP\invitation\invitations\userRoleAssignment\payload\UserRoleAssignmentInvitePayload; -use PKP\user\User; class UserRoleAssignmentInviteManagerDataResource extends BaseUserRoleAssignmentInviteResource {