Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for log message handlers #2347

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Jan 22, 2025

DH-18086, DH-18085: Support for log message handlers in the gRPC transport

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.74%. Comparing base (675b110) to head (9c67ac8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2347   +/-   ##
=======================================
  Coverage   46.74%   46.74%           
=======================================
  Files         705      705           
  Lines       39054    39054           
  Branches     9762     9762           
=======================================
  Hits        18256    18256           
  Misses      20787    20787           
  Partials       11       11           
Flag Coverage Δ
unit 46.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles marked this pull request as ready for review January 23, 2025 00:59
@bmingles bmingles requested review from a team and vbabich and removed request for a team January 23, 2025 00:59
@bmingles bmingles merged commit cbab7a2 into deephaven:main Jan 23, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
@bmingles bmingles deleted the DH-18086-3_grpc-logging branch January 23, 2025 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants