From 5f74320aa01420c8cc8dba904433c10604d66e44 Mon Sep 17 00:00:00 2001
From: Colin Alworth <colinalworth@deephaven.io>
Date: Fri, 17 Jan 2025 10:55:50 -0600
Subject: [PATCH 1/2] fix: Add semi-require "webhook-type" to slack actions

Our slack actions appear to be workflows, except for the image notify
step, which is an app with an incoming webhook - assigned the
webhook-trigger accordingly.

Also added build summary URLs for nightly check and publish.

Follow-up #6384
---
 .github/workflows/create-docs-issues.yml  | 1 +
 .github/workflows/nightly-check-ci.yml    | 3 ++-
 .github/workflows/nightly-image-check.yml | 1 +
 .github/workflows/nightly-publish-ci.yml  | 3 ++-
 4 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/create-docs-issues.yml b/.github/workflows/create-docs-issues.yml
index 8885c92407d..20b147ec4e8 100644
--- a/.github/workflows/create-docs-issues.yml
+++ b/.github/workflows/create-docs-issues.yml
@@ -32,6 +32,7 @@ jobs:
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL_DEVREL }}
         with:
+          webhook-type: webhook-trigger
           payload: |
             {
               "repository": "${{ github.repository }}",
diff --git a/.github/workflows/nightly-check-ci.yml b/.github/workflows/nightly-check-ci.yml
index 777bcef3cca..2eae6bd46b9 100644
--- a/.github/workflows/nightly-check-ci.yml
+++ b/.github/workflows/nightly-check-ci.yml
@@ -104,9 +104,10 @@ jobs:
         id: slack-nightly-failure
         if: ${{ failure() && github.repository_owner == 'deephaven' && github.ref == 'refs/heads/main' }}
         with:
+          webhook-type: webhook-trigger
           payload: |
             {
-              "slack_message": "Nightly build failure in ${{ matrix.gradle-task }} on Java ${{ matrix.test-jvm-version }} @ ${{ github.head_ref }} ${{ github.sha }}"
+              "slack_message": "Nightly build failure in ${{ matrix.gradle-task }} on Java ${{ matrix.test-jvm-version }} @ ${{ github.head_ref }} ${{ github.sha }}" ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
             }
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_NIGHTLY_FAILURE }}
diff --git a/.github/workflows/nightly-image-check.yml b/.github/workflows/nightly-image-check.yml
index d5745431886..4e8fc1da4f2 100644
--- a/.github/workflows/nightly-image-check.yml
+++ b/.github/workflows/nightly-image-check.yml
@@ -41,4 +41,5 @@ jobs:
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL_DHC_NOTIFY }}
         with:
+          webhook-type: incoming-webhook
           payload: '{"repository": "${{ github.repository }}", "message": "${{ github.workflow }}/${{ github.job }} failure, some image is out of date", "link": "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"}'
diff --git a/.github/workflows/nightly-publish-ci.yml b/.github/workflows/nightly-publish-ci.yml
index 0ebba57c54b..eda42e54620 100644
--- a/.github/workflows/nightly-publish-ci.yml
+++ b/.github/workflows/nightly-publish-ci.yml
@@ -59,9 +59,10 @@ jobs:
         id: slack-nightly-failure
         if: failure()
         with:
+          webhook-type: webhook-trigger
           payload: |
             {
-              "slack_message": "Nightly publish failure @ ${{ github.head_ref }} ${{ github.sha }}"
+              "slack_message": "Nightly publish failure @ ${{ github.head_ref }} ${{ github.sha }} ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
             }
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_NIGHTLY_FAILURE }}

From 7f69e7f91d7161526aa350ad1dba94a409044da9 Mon Sep 17 00:00:00 2001
From: Colin Alworth <colinalworth@deephaven.io>
Date: Fri, 17 Jan 2025 20:02:36 -0600
Subject: [PATCH 2/2] Nightly image check should be a webhook-trigger

---
 .github/workflows/nightly-image-check.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/nightly-image-check.yml b/.github/workflows/nightly-image-check.yml
index 4e8fc1da4f2..dc207fd005a 100644
--- a/.github/workflows/nightly-image-check.yml
+++ b/.github/workflows/nightly-image-check.yml
@@ -41,5 +41,5 @@ jobs:
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL_DHC_NOTIFY }}
         with:
-          webhook-type: incoming-webhook
+          webhook-type: webhook-trigger
           payload: '{"repository": "${{ github.repository }}", "message": "${{ github.workflow }}/${{ github.job }} failure, some image is out of date", "link": "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"}'