From e9a13da63e94d8dbcc57822aa93226106188c57f Mon Sep 17 00:00:00 2001 From: Nathaniel Bauernfeind Date: Tue, 9 Jan 2024 16:33:04 -0700 Subject: [PATCH] Devin's feedback --- .../server/console/ConsoleServiceGrpcImpl.java | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/server/src/main/java/io/deephaven/server/console/ConsoleServiceGrpcImpl.java b/server/src/main/java/io/deephaven/server/console/ConsoleServiceGrpcImpl.java index 78ef27eb2a5..864d1c1ad51 100644 --- a/server/src/main/java/io/deephaven/server/console/ConsoleServiceGrpcImpl.java +++ b/server/src/main/java/io/deephaven/server/console/ConsoleServiceGrpcImpl.java @@ -312,14 +312,12 @@ public StreamObserver autoCompleteStream( "from deephaven_internal.auto_completer import jedi_settings ; jedi_settings.set_scope(globals())"); settings[0] = (PyObject) scriptSession.getVariable("jedi_settings"); } catch (Exception err) { - if (err instanceof QueryScope.MissingVariableException) { - if (!ALREADY_WARNED_ABOUT_NO_AUTOCOMPLETE.getAndSet(true)) { - log.error().append("Autocomplete package not found; disabling autocomplete.").endl(); - log.error().append("Add the jvm flag '-D").append(DISABLE_AUTOCOMPLETE_FLAG) - .append("=true' to disable this message.").endl(); - } - } else { - log.error().append("Error trying to enable jedi autocomplete").append(err).endl(); + if (!ALREADY_WARNED_ABOUT_NO_AUTOCOMPLETE.getAndSet(true)) { + log.error().append("Autocomplete package not found; disabling autocomplete.").endl(); + log.error().append("Do you need to install the autocomplete package?").endl(); + log.error().append(" pip install deephaven-core[autocomplete]==").endl(); + log.error().append("Add the jvm flag '-D").append(DISABLE_AUTOCOMPLETE_FLAG) + .append("=true' to disable this message.").endl(); } } boolean canJedi = settings[0] != null && settings[0].call("can_jedi").getBooleanValue();