From a007d3f017e96238c23d318810ed355b553d4b3f Mon Sep 17 00:00:00 2001 From: Chip Kent Date: Fri, 15 Dec 2023 09:36:28 -0700 Subject: [PATCH] Address review comments. Made BusinessCalendar and Calendar constructors package so that they can be converted to interfaces in the future. --- .../main/java/io/deephaven/time/calendar/BusinessCalendar.java | 2 +- .../time/src/main/java/io/deephaven/time/calendar/Calendar.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/engine/time/src/main/java/io/deephaven/time/calendar/BusinessCalendar.java b/engine/time/src/main/java/io/deephaven/time/calendar/BusinessCalendar.java index 352ae102e6b..139c1c86838 100644 --- a/engine/time/src/main/java/io/deephaven/time/calendar/BusinessCalendar.java +++ b/engine/time/src/main/java/io/deephaven/time/calendar/BusinessCalendar.java @@ -147,7 +147,7 @@ private YearData getYearData(final int year) { * is different from the schedule for a standard business day or weekend. * @throws RequirementFailure if any argument is null. */ - public BusinessCalendar(final String name, final String description, final ZoneId timeZone, + BusinessCalendar(final String name, final String description, final ZoneId timeZone, final LocalDate firstValidDate, final LocalDate lastValidDate, final CalendarDay standardBusinessDay, final Set weekendDays, final Map> holidays) { diff --git a/engine/time/src/main/java/io/deephaven/time/calendar/Calendar.java b/engine/time/src/main/java/io/deephaven/time/calendar/Calendar.java index 1cb624c171a..127220608fe 100644 --- a/engine/time/src/main/java/io/deephaven/time/calendar/Calendar.java +++ b/engine/time/src/main/java/io/deephaven/time/calendar/Calendar.java @@ -41,7 +41,7 @@ public class Calendar { * @param timeZone calendar time zone. * @throws RequirementFailure if any parameter is {@code null} */ - public Calendar(final String name, final String description, final ZoneId timeZone) { + Calendar(final String name, final String description, final ZoneId timeZone) { this.name = Require.neqNull(name, "name"); this.description = Require.neqNull(description, "description"); this.timeZone = Require.neqNull(timeZone, "timeZone");