Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark runs with training separately than runs that use settings file #1006

Open
fgregg opened this issue May 5, 2022 · 3 comments
Open

Comments

@fgregg
Copy link
Contributor

fgregg commented May 5, 2022

@NickCrews, if i understand the benchmarking code correctly, the first time a benchmark runs it will create a settings file, and then in all subsequent runs, the benchmarking code will use that settings file.

It would be very helpful if we could separate this out, so we had benchmarks runs where each run there was not training, and other runs where each run used a settings file.

does that make sense?

@fgregg
Copy link
Contributor Author

fgregg commented May 5, 2022

actually, ideal would be to track three things distinctly

  • track time training
  • track time matching if i trained
  • track time matching if i read from settings file

@NickCrews
Copy link
Contributor

Yes that makes sense and is possible. Will try to get to this in next couple days.

Also do you think adding a larger dataset would be useful? Not sure how meaningful these small datasets are, eg howuch of that 50Mb of peak memory you mentioned is just overhead

@fgregg
Copy link
Contributor Author

fgregg commented May 5, 2022

would love to have some bigger data sets. those would probably need to be run on demand or nightly to and on every push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants