Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worst triggerArea #10

Open
bikevit2008 opened this issue Feb 9, 2024 · 4 comments
Open

Worst triggerArea #10

bikevit2008 opened this issue Feb 9, 2024 · 4 comments

Comments

@bikevit2008
Copy link

In sdk6 utils library was better, for example: i need lift trigger area i could do one trigger area with 26 meters of building for access from all floors -- in current library execution i can't do it, trigger area works only from bottom + 3 meters, all upper part doesn't work. And one stupid tech and manage behavior -- in decentraland engine position for shape use center point, here debug shape starts from center point of the shape, but trigger area start work only from center point, but bottom half part of the shape doesn't works. You did mistake in general concept of position point in decentraland engine and in this library.

Library too much draft.

I saw source code of trigger area, look likes too much science based language to naming and something like differential or integral in rude view with cycles for areas like for chunks, too much academic term intersection, but in code realisation just Vector3 substract and add methods.

Fake strong minded code, which didn't correctly simple things.
I did fast simpler analog for 62 strings of code which works in simpler cases VS your 473 strings of code with over engineering and without ability to do though simple thingas

@bikevit2008
Copy link
Author

https://gist.github.com/bikevit2008/42d2c2476328e705389d5fccdc1bcb4a

My simple fast coded case, you can use it for develop in future and do most quality

@bikevit2008
Copy link
Author

bikevit2008 commented Feb 14, 2024

Hey!
You must know my variant isn't completed research and development for rewriting SDK7 utils, it's just my simpler variant with simple but 100% working functionality for simple things without layering and some optimizations

@aixaCode
Copy link

Hi @bikevit2008
Thank you for your feedback and the solution you've shared with us, we will definitely take a look at it.

Could you provide an example scene or more details on what problems you have encountered? This information will help us understand the issue better and consider your proposed solution for future improvements.

Looking forward to hearing more from you.

@bikevit2008
Copy link
Author

Of course, a little bit later i'll give details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants