Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.5 update issue #30

Open
fuggfuggfugg opened this issue Jan 27, 2016 · 24 comments
Open

3.5 update issue #30

fuggfuggfugg opened this issue Jan 27, 2016 · 24 comments

Comments

@fuggfuggfugg
Copy link

Hi, first time installing a plugin. I just updated to 3.5 and installed the plugin via sketch toolbox. I tried this plugin for the first time and doesn't seem to work.

screen shot 2016-01-26 at 10 01 25 pm

@mikeprecious
Copy link

I've been using the plugin for a while. The 3.5 update seems to have created an incompatibility with this plugin. I'm getting the same results you shared.

@octavioamu
Copy link

Same error here version 3.5.1 (25234)

@donysukardi
Copy link

And I thought I was the only one. Phew..

@denswor
Copy link

denswor commented Jan 28, 2016

Dynamic group created without background layer.

When you are updating existing (created in previous version of sketch) dynamic group it works fine.

@willian
Copy link

willian commented Jan 29, 2016

Any news about this?

@willian
Copy link

willian commented Jan 29, 2016

I think this plugin is not maintained anymore, lat commit from April 2015... Do you guys have an alternative?

@denswor
Copy link

denswor commented Feb 1, 2016

Well if it's suitable to you, when you are creating Dynamic group with 0:0:0:0 text layer and without BG layer just create a BG layer with Rectangle tool and it will work )

I don't know any alternatives.

@wssrstrm
Copy link

wssrstrm commented Feb 2, 2016

I'm not finding this alternative method to work.

@mludowise
Copy link

I've had trouble using this plugin since before Sketch 3.5 and switched to sketch-relabel-button:
https://github.com/kenmoore/sketch-relabel-button

It's more flexible than Dynamic Button and I'm currently working on a fork to support additional text alignments.

@denswor
Copy link

denswor commented Feb 2, 2016

@wssrstrm sorry i don't know what exactly going wrong on your side. this is how it works for me (until it will be fixed by @ddwht )

https://dl.dropboxusercontent.com/u/4616706/sketch-dynamic-button.mov

@octavioamu
Copy link

@denswor now I get your alternative I wasn't renaming the bg to BG.

@TheDamianHdez
Copy link

Thank you @denswor It helps!

@keano12
Copy link

keano12 commented Feb 5, 2016

Yup doesn't work for me either.

@soulrider911
Copy link

same issue here does not work in 3.5

@gbrsr
Copy link

gbrsr commented Feb 11, 2016

Doesn't work with 3.5 for me either (just adding to the pool)

@derlewan
Copy link

same issue here does not work in 3.5

@fuggfuggfugg
Copy link
Author

@mikeprecious @donysukardi @willian @wssrstrm @mludowise @denswor @octavioamu @TheDamianHdez @keano12 @soulrider911 @gbrsr @derlewan

Greetings Guys,
I was the one to log this issue. I took this day and fixed the issue myself. Here is the new repo for you to play around with. The demo video explains how to download and install.

https://github.com/fuggfuggfugg/sketch-dynamic-button-3.5

Enjoy

@mikeprecious
Copy link

Works like a charm. Appreciated - thanks!

@soulrider911
Copy link

bingo! Awesome

@ambersawaya
Copy link

Thanks @fuggfuggfugg, works great!

@fuggfuggfugg
Copy link
Author

fuggfuggfugg commented May 20, 2016

@mikeprecious @donysukardi @willian @wssrstrm @mludowise @denswor @octavioamu @TheDamianHdez @keano12 @soulrider911 @gbrsr @derlewan

Greetings again guys, Just a reminder. I've updated my plugin to work with 3.8. You will need to re-install the plugin. Sorry for the inconvenience.

@dannyjpwilliams
Copy link

dannyjpwilliams commented Dec 13, 2016

@fuggfuggfugg update for 41.2 anytime soon? Experiencing same error now as before.

@fuggfuggfugg
Copy link
Author

@dannyjpwilliams It is working for me. Re-install your plugin, I did some updates day before.

Let me know if it isn't.

@dannyjpwilliams
Copy link

dannyjpwilliams commented Dec 14, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests