Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only showing trash pickup not recycle ... #1

Open
jpettitt opened this issue Feb 16, 2023 · 10 comments
Open

Only showing trash pickup not recycle ... #1

jpettitt opened this issue Feb 16, 2023 · 10 comments

Comments

@jpettitt
Copy link

We have a 2 week recycle pickup and weekly trash pickup but I'm only seeing an entity for trash pickup ... did I miss something in the config?

@jpettitt
Copy link
Author

Never mind, a restart fixed it and it pickup up the recycle schedule.

@dcmeglio
Copy link
Owner

I'm reopening this because I do think there is an issue. The WM api sucks and is incredibly slow. I suspect you hit a timeout in an area I didn't yet add code to handle. Any chance you see any errors in your logs?

@dcmeglio dcmeglio reopened this Feb 17, 2023
@brooksben11
Copy link

I had this exact same thing happen when I originally set it up (but in my case, only recycling showed up). Tried restarting the integration (and maybe HA too). Regardless, at some point (within a day or 2) they both showed up and have been since.

BTW, @dcmeglio thanks for making this! Super-handy having my trash notifications automatically adjusted for holidays and weather delays.

@dcmeglio
Copy link
Owner

I will give you a heads up, the holiday/weather delay stuff is a bit flaky. The way their API works is I get a text string back like "Due to Martin Luther King Day your pickup will be delayed by 1 day." so I have to parse that string manually. One thing I did not add support for (not sure the best way to handle it) is sometimes the string for my area will say something like "Due to Christmas your pickup will be delayed by 1 day except for the city of Somewhere." I don't really have a good way to determine if you live in the city listed. I might add a configuration where you can specify the city name or something like that. The strings are tricky because sometimes they're more like "Your pickup will not be delayed by the Presidents Day holiday." so I pretty much have to try to read the string and figure it out... terrible API design but of course they weren't really expecting someone to build this integration!

In any case, if you find it does NOT properly adjust for a holiday, please login to wm.com, go to the View ETA and Schedule page, and submit an issue here providing the text that's in the Holiday Schedule area. Since they're text strings it's totally possible they're manually entered by humans and may differ in different regions.

Also for the record, we've had a mild winter where I live this year so I haven't actually had a real world test of weather delays yet :)

@brooksben11
Copy link

Oh man, that is a terrible API design!

Any thoughts of adding an additional sensor with the raw text string, maybe as just a diagnostic sensor? I know that would be really helpful for me to help keep an eye on it. Or maybe even 3 total: your 'normal' next pickup date, the integration's guess as to the actual date and then the raw text? That could be handy to quickly check without having to login to WM (I honestly didn't know I could do that prior to this anyway).

Thanks again for your work on this!

We've had several weather delays here, but I think we might be done with them for the winter and I only just got this setup!

@jasonsf
Copy link

jasonsf commented Feb 20, 2023

I'm reopening this because I do think there is an issue. The WM api sucks and is incredibly slow. I suspect you hit a timeout in an area I didn't yet add code to handle. Any chance you see any errors in your logs?

I am seeing only one of my two pickups as well. Logs show a timeout.

Logger: homeassistant.components.sensor
Source: runner.py:128
Integration: Sensor (documentation, issues)
First occurred: 10:32:43 PM (3 occurrences)
Last logged: 10:37:15 PM

Setup of sensor platform waste_management is taking over 10 seconds.

@dcmeglio
Copy link
Owner

That’s not a timeout. Just says it took more than 10 seconds. Do you see any errors or just that warning?

@jasonsf
Copy link

jasonsf commented Feb 20, 2023

That’s not a timeout. Just says it took more than 10 seconds. Do you see any errors or just that warning?

Ah, you are right. And now, this morning, it has created the second entity. So apparently it is working. Just that warning.

@dcmeglio
Copy link
Owner

Darn so nothing in the logs? The fact that it showed up this morning indicates there was a timeout. I'm adding better logging today. Now that a few people are using this maybe we can track it down.

@bobloadmire
Copy link

Same issue here. Weekly trash showing, biweekly recycle not showing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants