Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Urgent] Bug: Build package configs from main branch (or master) #70

Closed
VersusFacit opened this issue Sep 13, 2021 · 0 comments · Fixed by #74
Closed

[Urgent] Bug: Build package configs from main branch (or master) #70

VersusFacit opened this issue Sep 13, 2021 · 0 comments · Fixed by #74

Comments

@VersusFacit
Copy link
Contributor

VersusFacit commented Sep 13, 2021

image

We need to ensure the hubcap script is prepared to handle packages with main, then prioritize that if there's no master branch. Currently, master is hardcoded into the script. We need main conditional logic that uses main then master when looking for commit shas to change into package specs. Otherwise, newer versions won't be added to hub.getdbt.com; the script will just break for any repo that does not retain a master branch.

Good news though! Because package specs depend only on commit shas, nothing has been changed for previous versions of packages.

This will partially address issue #69 .

@VersusFacit VersusFacit changed the title Urgent: Build package configs from main branch (or master) Bug: Build package configs from main branch (or master) Sep 13, 2021
@VersusFacit VersusFacit changed the title Bug: Build package configs from main branch (or master) [Urgent] Bug: Build package configs from main branch (or master) Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant