-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update next link on "Data tests" page to "Unit tests" page #5542
Labels
content
Improvements or additions to content
improvement
Use this when an area of the docs needs improvement as it's currently unclear
Comments
sdopoku
added
content
Improvements or additions to content
improvement
Use this when an area of the docs needs improvement as it's currently unclear
labels
May 22, 2024
mirnawong1
added a commit
that referenced
this issue
May 24, 2024
adds a pagination next to unit tests as the user was getting stuck in a loop bc the 'next' page was taking them to the same page they're on: data tests Resolves #5542
great flag @sdopoku ! i've created a quick pr here to fix this: https://github.com/dbt-labs/docs.getdbt.com/compare/current...mirnawong1-patch-28?quick_pull=1 tl;dr, we needed to add a |
mirnawong1
added a commit
that referenced
this issue
May 29, 2024
adds a pagination next to unit tests as the user was getting stuck in a loop bc the 'next' page was taking them to the same page they're on: data tests Resolves #5542 ## What are you changing in this pull request and why? <!--- Describe your changes and why you're making them. If related to an open issue or a pull request on dbt Core, then link to them here! To learn more about the writing conventions used in the dbt Labs docs, see the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md). --> ## Checklist <!-- Uncomment when publishing docs for a prerelease version of dbt: - [ ] Add versioning components, as described in [Versioning Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages) - [ ] Add a note to the prerelease version [Migration Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade) --> - [ ] Review the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md) so my content adheres to these guidelines. - [ ] For [docs versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning), review how to [version a whole page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version) and [version a block of content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content). - [ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch." Adding or removing pages (delete if not applicable): - [ ] Add/remove page in `website/sidebars.js` - [ ] Provide a unique filename for new pages - [ ] Add an entry for deleted pages in `website/vercel.json` - [ ] Run link testing locally with `npm run build` to update the links that point to deleted pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content
Improvements or additions to content
improvement
Use this when an area of the docs needs improvement as it's currently unclear
Contributions
Link to the page on docs.getdbt.com requiring updates
https://docs.getdbt.com/docs/build/data-tests
What part(s) of the page would you like to see updated?
The link to the next page at the bottom of this page currently redirects to the same page. It should, however, be linked to the Unit tests page: https://docs.getdbt.com/docs/build/unit-tests.
I tried the "Edit this page" feature but could not locate the code to fix this myself. 😢 See the screenshot below:
Additional information
No response
The text was updated successfully, but these errors were encountered: