Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest v12 for dbt Core v1.8 / dbt Cloud KoLV #5525

Closed
1 task done
jtcohen6 opened this issue May 17, 2024 · 2 comments · Fixed by #5526
Closed
1 task done

Add manifest v12 for dbt Core v1.8 / dbt Cloud KoLV #5525

jtcohen6 opened this issue May 17, 2024 · 2 comments · Fixed by #5526
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@jtcohen6
Copy link
Collaborator

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/artifacts/manifest-json

What part(s) of the page would you like to see updated?

dbt Core v1.8 is using manifest v12

Additional information

https://schemas.getdbt.com/dbt/manifest/v12/index.html

@jtcohen6 jtcohen6 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels May 17, 2024
@jtcohen6 jtcohen6 added this to the dbt Core v1.8 Documentation milestone May 17, 2024
@dbeatty10
Copy link
Contributor

Draft PR here: #5526

Here's what the table looks like currently:

dbt Core version Manifest version
v1.7 v11
v1.6 v10
v1.5 v9

Here's what it will look like after adding one new row:

dbt Core version Manifest version
v1.8 v12
v1.7 v11
v1.6 v10
v1.5 v9

Do we also want to add a new column to indicate which manifest schema version is associated with dbt Cloud KoLV (Keep on Latest Version)?

dbt Core version dbt Cloud KoLV Manifest version
v1.8 v12
v1.7 v11
v1.6 v10
v1.5 v9

@mirnawong1
Copy link
Contributor

@dbeatty10 i love the table idea! i'm going to loop in the docs leads here (@matthewshaver and @nghi-ly). if I'm understanding this correctly, i wonder if it's easier to just have a sentence in there somewhere so it's clear that kolv = latest manifest version. that way we don't have to maintain the column for every new version?

'e.g. if you select 'Keep on latest version,' you'll always use the newest dbt Core version and its corresponding manifest schema. for example, if the latest dbt Core version is v1.8 with a manifest schema of v12, then 'Keep on latest version' will use manifest schema v12.'

mirnawong1 added a commit that referenced this issue May 17, 2024
[Preview](https://docs-getdbt-com-git-dbeatty10-patch-1-dbt-labs.vercel.app/reference/artifacts/manifest-json)

## What are you changing in this pull request and why?

resolves #5525

dbt Core v1.8 is using manifest v12.

dbt Cloud KoLV (Keep on Latest Version) is also using manifest v12
currently.

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants