Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow allow squash merging #915

Closed
dbeatty10 opened this issue Jun 5, 2024 · 1 comment
Closed

Only allow allow squash merging #915

dbeatty10 opened this issue Jun 5, 2024 · 1 comment

Comments

@dbeatty10
Copy link
Contributor

Describe the under the hood change

Currently, there are two options enabled for merging PRs in dbt-utils:

  • squash merging
  • rebase merging

But we should update it to align with dbt-core, et al:

image

Who will this benefit?

This will benefit maintainers -- lower decision fatigue by only giving a single option.
This will also prevent rebase merges which will write the commit history differently and maybe less readable.

@dbeatty10
Copy link
Contributor Author

Done by updating the settings.

🎩

Working as expected:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant