Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake/wavpackcpu.cmake is missing from the tar.xz archive #194

Open
jonaski opened this issue Jan 28, 2025 · 5 comments
Open

cmake/wavpackcpu.cmake is missing from the tar.xz archive #194

jonaski opened this issue Jan 28, 2025 · 5 comments

Comments

@jonaski
Copy link

jonaski commented Jan 28, 2025

CMake Error at CMakeLists.txt:127 (include):
  include could not find requested file:

    cmake/wavpackcpu.cmake


CMake Error at CMakeLists.txt:128 (WavPack_DetectTargetCPUArchitectures):
  Unknown CMake command "WavPack_DetectTargetCPUArchitectures".

@jonaski
Copy link
Author

jonaski commented Jan 28, 2025

wavpack-config.cmake.in is also missing

@dbry
Copy link
Owner

dbry commented Jan 28, 2025

Thanks!

@vtorri
Copy link

vtorri commented Jan 29, 2025

maybe you could add github CI to test the compilation with the autotools and cmake for mac, linux and windows ? this will avoid such problems

@jonaski
Copy link
Author

jonaski commented Jan 31, 2025

@dbry Thanks. I can add GitHub CI if you want, let me know.

@jonaski jonaski closed this as completed Jan 31, 2025
@dbry
Copy link
Owner

dbry commented Jan 31, 2025

I agree that having CI would be great. It used to be set up for Travis and even ran the fuzzing regressors and I think some version of the libwavpack test (although that can be CPU hungry). You can see the file here. Of course now it makes more sense to just use GitHub CI.

That would not have caught this specific issue because it just ran from the repo (it did not create a tarball and then run in that). But I don't think it's that important because I won't be forgetting to test cmake from the tarball again... 😄

@jonaski if you're up for putting this together that would be great! This kind of stuff is not really in my wheelhouse.

@dbry dbry reopened this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants