Schema#ref does not apply custom configuration options

[ahx]

Hi. What I would like to do is to use insert_property_defaults: true for subschemas that are adressed via Schema#ref without globally changing JSONSchemer.configuration.
But currently that does not seem to be possible, because Schema#ref does not apply the custom local options, but only uses the global configuration and passing insert_property_defaults: true to Schema#validate is not supported.

Here is an example:

doc = JSONSchemer.openapi(contents, insert_property_defaults: true)
content_schema = doc.ref('/components/schemas/MySchema')
content_schema.validate(data) # Fails, because insert_property_defaults is not applied (false)

# Now this (hack) makes it apply the option, but also changes global configuration, which I don't want:
doc = JSONSchemer.openapi(contents,)
content_schema = doc.ref('/components/schemas/MySchema')
content_schema.configuration.insert_property_defaults = true
content_schema.validate(data) # Succeeds

puts JSONSchemer.configuration.insert_property_defaults # => true

If you have a suggestion for an API to solve this, I'd be happy to try to create a PR for that.

[ahx]

Ha! I've found a solution.

  configuration = JSONSchemer::Configuration.new(insert_property_defaults: true)
  doc = JSONSchemer.openapi(resolved, configuration:)
  content_schema = doc.ref('/components/schemas/MySchema')
  content_schema.validate(data) # Succeeds! 

Thanks! 🦆
Feel free to close this issue.

[davishmcclurg]

Hi @ahx, sorry for the delay here. I'm going to reopen this because I think it's an issue that subschemas don't inherit some options. It seems like we need to merge (some of?) the initialize options back into configuration:

json_schemer/lib/json_schemer/schema.rb

Line 78 in 2a239b6

@configuration = configuration

so that they get passed to the ref schema:

json_schemer/lib/json_schemer/schema.rb

Line 191 in 2a239b6

:configuration => configuration,

Let me know if you want to work on a fix!

[ahx]

Hey David, I agree and I would like to work on a fix.
What I would also like is support for being able to overwrite configuration per subschema, Like doc.ref('/components/schemas/MySchema', after_property_validation: myproc)

I'll try to work on this. If I don't get back here until the new year, feel free to poke me.

[tonobo]

Yep, also hit this case. The library defaults get inherited.

json_schemer/lib/json_schemer/draft202012/vocab/applicator.rb

Line 232 in 2a239b6

if root.before_property_validation.any?

it took me a moment to figure out that “root” is not “root”, but in the “parsed” loop below it saw the properties, then I came up with the issue.

[davishmcclurg]

@ahx have you had a chance to work on this? I've got another fix to merge/release and I'm hoping to include this as well.

[ahx]

My approach was to clone the base config and merge it with incoming parameters (see commit). And I wanted to merge the many arguments of Schema#new into one **options. I got a failing test to pass, but that resulted in other things breaking, which I could not get my head around just yet. So I have not accomplished much here. I bet you can find a solution much faster than me. So don't feel held back if you find something working.

[davishmcclurg]

My approach was to clone the base config and merge it with incoming parameters (see commit). And I wanted to merge the many arguments of Schema#new into one **options.

Cool, I took a similar approach here: #208
If you have some time, do you mind testing it out to see if it fixes your original issue?

[davishmcclurg]

Fix released in 2.4.0