Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: if images is in page bundle only, but not resources it's not found #899

Closed
davidsneighbour opened this issue May 2, 2024 · 1 comment
Closed

bug: if images is in page bundle only, but not resources it's not found #899

davidsneighbour opened this issue May 2, 2024 · 1 comment
Assignees
@davidsneighbour
Labels
type:bug Bugfixes in codebase when something is not working.

Comments

@davidsneighbour
Copy link
Owner

I would expect any image inside of a page folder to be available in resources. Somehow that is not the case. Probably a bug in pictures module in the image finder function.
@davidsneighbour davidsneighbour added type:bug Bugfixes in codebase when something is not working. state:unconfirmed This issue needs to be reproduced. labels May 2, 2024
@davidsneighbour davidsneighbour self-assigned this May 2, 2024
@davidsneighbour davidsneighbour added state:confirmed This issue is confirmed. and removed state:unconfirmed This issue needs to be reproduced. labels May 2, 2024
davidsneighbour added a commit that referenced this issue May 2, 2024
@davidsneighbour
content(fix): add missing image resources
74b28a0 
see #899

Signed-off-by: Patrick Kollitsch <[email protected]>
@davidsneighbour
Copy link
Owner Author

not a bug :) or a different bug solved. basically the images were not found because the page that this happened to was embedded in another page and the page context was scrambled up.

connected and fixed to/in #911

@github-actions github-actions bot removed the state:confirmed This issue is confirmed. label May 5, 2024
davidsneighbour added a commit that referenced this issue May 5, 2024
@davidsneighbour
content(fix): remove unused resource objects
7fa1877 
see #899

Signed-off-by: Patrick Kollitsch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidsneighbour davidsneighbour

Labels
type:bug Bugfixes in codebase when something is not working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidsneighbour