Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Generalize Multi-pages images support #248

Open
Elad-Laufer opened this issue Jan 14, 2022 · 1 comment
Open

Proposal: Generalize Multi-pages images support #248

Elad-Laufer opened this issue Jan 14, 2022 · 1 comment

Comments

@Elad-Laufer
Copy link
Contributor

Elad-Laufer commented Jan 14, 2022

Instead of the current approach of trying to handle multipage images in each function in a specific way, or declaring the operation not supported we can consider the following:

  1. On the first operation that requires specific handling of pages, break a multipage image in to multiple images and hold them in a slice under ImageRef
  2. Apply the operation to each image independently
  3. On consecutive operations, if the slice exist continue applying them independently
  4. On export, Join the images back into a roll and then export the result - unless the target format does not support animation and in this case default to the first frame (add frame selection option?)
@Elad-Laufer
Copy link
Contributor Author

NOTE: How does holding multiple imageRef (one per page) affect memory pressure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant