Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write some tests for the toy environments #12

Open
david-lindner opened this issue Jan 11, 2019 · 3 comments
Open

Write some tests for the toy environments #12

david-lindner opened this issue Jan 11, 2019 · 3 comments

Comments

@david-lindner
Copy link
Owner

Tests are great!

@jvmncs
Copy link
Collaborator

jvmncs commented Jan 11, 2019

Looks like there were some unit tests merged in #14. Seems like a good start, but we'll also want to write some integration tests for safe-grid-agents and this one. Mainly, we'll want to test that changes here don't introduce breaking changes with what we do over there. Could be as simple as a single training/evaluation iteration of Q learning on each of the environments

@david-lindner
Copy link
Owner Author

I think the additions from #17 are fine as unittests for the toy environments.

Integration tests between the repos make a lot of sense! Just to clarify how you imagine this: We would add tests to this repo, that import safe-grid-agents, run a training and evaluation iteration and check that nothing crashes and something reasonable happens, correct?

@david-lindner david-lindner added the question Further information is requested label Jan 14, 2019
@david-lindner david-lindner added needs_clarification and removed question Further information is requested labels Jan 14, 2019
@jvmncs
Copy link
Collaborator

jvmncs commented Jan 14, 2019

Precisely! That seems sufficient for now, at least until we have better unit testing over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants