-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write some tests for the toy environments #12
Comments
Looks like there were some unit tests merged in #14. Seems like a good start, but we'll also want to write some integration tests for safe-grid-agents and this one. Mainly, we'll want to test that changes here don't introduce breaking changes with what we do over there. Could be as simple as a single training/evaluation iteration of Q learning on each of the environments |
I think the additions from #17 are fine as unittests for the toy environments. Integration tests between the repos make a lot of sense! Just to clarify how you imagine this: We would add tests to this repo, that import |
Precisely! That seems sufficient for now, at least until we have better unit testing over there. |
Tests are great!
The text was updated successfully, but these errors were encountered: