Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal is blank on iOS 13.1 #61

Closed
Willhay108-imprint opened this issue Oct 8, 2019 · 4 comments · Fixed by #64
Closed

Modal is blank on iOS 13.1 #61

Willhay108-imprint opened this issue Oct 8, 2019 · 4 comments · Fixed by #64

Comments

@Willhay108-imprint
Copy link

Willhay108-imprint commented Oct 8, 2019 •
edited
Loading

Which platform(s) does your issue occur on?

iOS

Please, provide the following version numbers that your issue occurs with:

1.2.1 of Datepicker, 13.1 for iOS.

Please, tell us how to recreate the issue in as much detail as possible.

Open up a date picker, the picker is there as I can scroll the dates and feel the haptic feedback, however nothing is rendered inside the modal it is completely blank

Image from iOS (3)
@dan-sel-tx
Copy link

I believe this is happening due to Dark Mode being set on the iPhone, a new Apple feature?
This is the behavior we are seeing when set to dark mode, though we do see the text we set for Choose a Date. We have theme: 'dark' set for the module, and have tried all the others with no fix yet.

@davecoffin
Copy link
Owner

Yea, so this is definitely dark mode turning the picker white. I can look into fixing this but if you need an urgent fix you can add this to Info.plist and it will use the light UI style for your app, which is probably what youll want to do anyway unless you are making the effort of your whole UI respecting the new feature

<key>UIUserInterfaceStyle</key>
<string>Light</string>

@dan-sel-tx
Copy link

Can confirm this solves this issue, and many others due to the mode change. Thanks Dave! This is one my favorite plugins, very well done.
Would love to have this same module with the ability to pass in a list of string items into a scroll picker.
One can dream... :)

@Willhay108-imprint
Copy link
Author

Yep, the plist change indeed fixes it. Thank you very much!

@Logikgate Logikgate mentioned this issue Feb 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes display on dark mode flypapertech/nativescript-modal-datetimepicker
3 participants
@davecoffin @dan-sel-tx @Willhay108-imprint