Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] matching-negate-char is broken #2070

Closed
2 tasks done
jaki opened this issue Jan 3, 2025 · 4 comments
Closed
2 tasks done

[BUG] matching-negate-char is broken #2070

jaki opened this issue Jan 3, 2025 · 4 comments
Labels
Milestone

Comments

@jaki
Copy link
Contributor

jaki commented Jan 3, 2025

Rofi version (rofi -v)

1.7.6

Configuration

https://gist.github.com/jaki/1e91c8f49be56d4ee288f71489baf459/raw/e99b21117cad712c6a537ec5174be3b40e537586/config.rasi

Theme

default

Timing report

n/a

Launch command

rofi -show run

Step to reproduce

Prepare config:

mv ~/.config/rofi ~/.config/rofi.$RANDOM
mkdir ~/.config/rofi
cat >~/.config/rofi/config.rasi <<EOT
configuration {
	matching-negate-char: '-';
}
EOT
git checkout c6f3cfb7d7c711f0a59fb364af4f74d9996c57e2~
make
./rofi -show run

...nothing wrong

git checkout c6f3cfb7d7c711f0a59fb364af4f74d9996c57e2
make
./rofi -show run

...throws error

/.../.config/rofi/config.rasi:1:16: Option: matching-negate-char needs to be set with a character not a String.

Expected behavior

nothing wrong

Actual behavior

aforementioned error

Additional information

Commit c6f3cfb breaks what PR #1131 fixed. Documentation still indicates

Character

Character value is always surrounded by single quotes (') and should contain a single character. It supports escaping.

matching-negate-char: '-';

but commit c6f3cfb goes against that. I tried reverting c6f3cfb but it causes some merge conflicts that I don't want to deal with.

Using wayland display server protocol

  • No, I don't use the wayland display server protocol

I've checked if the issue exists in the latest stable release

  • Yes, I have checked the problem exists in the latest stable version
@jaki jaki added the bug label Jan 3, 2025
@DaveDavenport
Copy link
Collaborator

yeah, that change should not have been committed.

@DaveDavenport
Copy link
Collaborator

Worked around it in GIT. Removed the 'Character' type from the CSS parser and internally use the string type for the character, that should fix this. If you can please test.

@DaveDavenport DaveDavenport added this to the 1.7.7 milestone Jan 3, 2025
@jaki
Copy link
Contributor Author

jaki commented Jan 4, 2025

Yes, de4e10a fixes it.

@jaki jaki closed this as completed Jan 4, 2025
Copy link

github-actions bot commented Feb 5, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants