Broker statefulset no accounted for in PulsarSQL configmap

[ddieruf]

The pulsarSql configmap assumes broker is a deployment by using .Values.broker.component

pulsar-helm-chart/helm-chart-sources/pulsar/templates/pulsarSql/configmap-coordinator.yaml

Line 75 in 014a542

pulsar.broker-service-url=http://{{ template "pulsar.fullname" . }}-{{ .Values.broker.component }}.{{ template "pulsar.serviceDnsSuffix" . }}:8080

When using brokerSts, PulsarSql can not find the broker because it's .Values.brokerSts.component.

[michaeljmarshall]

Thanks for opening this issue @ddieruf. I think there are multiple places in the helm chart with this bug. the easiest solution is to configure .Values.brokerSts.component: broker. A better solution would use a templating function to figure out the "right" component name to use without duplicating the logic everywhere. Is this issue blocking you? Are you interested in contributing a fix?

[ddieruf]

I'll just use the workaround for now, thx.

…

On Tue, Nov 15, 2022 at 11:24 AM Michael Marshall ***@***.***> wrote: Thanks for opening this issue @ddieruf <https://github.com/ddieruf>. I think there are multiple places in the helm chart with this bug. the easiest solution is to configure .Values.brokerSts.component: broker. A better solution would use a templating function to figure out the "right" component name to use without duplicating the logic everywhere. Is this issue blocking you? Are you interested in contributing a fix? — Reply to this email directly, view it on GitHub <#267 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEBJG3BANZ45FTEGBBAJ353WIO2LJANCNFSM6AAAAAASBBQT54> . You are receiving this because you were mentioned.Message ID: ***@***.***>