Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pre-built recombine (Mac) #80

Closed
16 of 24 tasks
rolyp opened this issue Dec 30, 2020 · 1 comment
Closed
16 of 24 tasks

Switch to pre-built recombine (Mac) #80

rolyp opened this issue Dec 30, 2020 · 1 comment

Comments

@rolyp
Copy link
Collaborator

rolyp commented Dec 30, 2020

Use the pre-built recombine binary (terrylyons/recombine#25). Mac only for now as pre-built binaries for Linux and Windows are WIP. May significantly reduce the case for #73 and #75.

  • retrieve installer via artifacts API – looks like a huge pain in the butt
  • retrieve installer via dawidd6/action-download-artifact
    • repo argument parses weirdly (see here – looks like terrylyons/recombine is correct syntax)
    • whatever string I pass to repo, Action fails with Error: Not Found (=404?); possible reasons:
      • secrets.GITHUB_TOKEN not found – no, that reports Input required and not supplied: github_token
      • release branch not found – no, that reports RunID: and then Not Found
      • artifact called build not found ❌ omitting name argument will download all artifacts
    • authenticate: secrets.RECOMBINE_LOGIN works (isn’t that a password, not an authentication token?)
  • retrieve installer (specific version for now) from the command line using curl
  • remove git-preamble.sh step
  • run cmake -- install step
    • INSTALL cannot find /Users/runner/work/recombine/recombine/build/recombine/recombine.framework
    • otool -l to inspect binaries for value(s?) of LC_RPATH in recombine binary:
      • recombine build, before test install: /opt/intel/compilers_and_libraries/mac/mkl/../compiler/lib
      • recombine build, after test install: /Users/runner/lyonstech/recombine.framework/Versions/C
      • esig pre-built version, before install: /opt/intel/compilers_and_libraries/mac/mkl/../compiler/lib
    • otool -D to look at “install name”: recombine/recombine.framework/Versions/C/recombine
    • decompose: path ofrecombine build (/Users/runner/work/recombine/recombine/build) + install name
  • add test_recombine step
@rolyp
Copy link
Collaborator Author

rolyp commented Jan 29, 2021

Aborting terrylyons/recombine#35 and related tasks, so this is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant