Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch user from appsmith #111

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fetch user from appsmith #111

wants to merge 3 commits into from

Conversation

bkowshik
Copy link

@bkowshik bkowshik commented Jan 6, 2025 •
edited
Loading

Fixes: #108

NOTE: This PR needs to be merged after merging #110 and deleting that branch.

Before this change

The value in last_updated_by (last column) is false.

test_activated|project_id|test_id                             |scenario_id   |priority|description                                 |impact|proposed_remediation|entity_id          |test_type         |column_name|column_description|test_parameters                                    |date_added                   |date_modified                |last_updated_by|
--------------+----------+------------------------------------+--------------+--------+--------------------------------------------+------+--------------------+-------------------+------------------+-----------+------------------+---------------------------------------------------+-----------------------------+-----------------------------+---------------+
true          |nsso_ayush|fea48f10-9fcc-3454-8d4f-9213589a58bb|INCONSISTENT-1|       8|Household size (hhsize) is a positive number|      |                    |all_nsso_ayush_data|expression_is_true|           |                  |{"expression": "hhsize is not null and hhsize > 0"}|2025-01-05 14:43:13.938 +0530|2025-01-05 14:43:13.938 +0530|false          |

After the change

The value in last_updated_by (last column) is picked from the appsmith object.

test_activated|project_id|test_id                             |scenario_id   |priority|description                                 |impact|proposed_remediation|entity_id          |test_type         |column_name|column_description|test_parameters                                    |date_added                   |date_modified                |last_updated_by|
--------------+----------+------------------------------------+--------------+--------+--------------------------------------------+------+--------------------+-------------------+------------------+-----------+------------------+---------------------------------------------------+-----------------------------+-----------------------------+---------------+
true          |nsso_ayush|d9732f5e-d837-3a5f-ad5c-7929316c1dc4|MISSING-1     |       3|Household size (hhsize) is not null         |      |                    |all_nsso_ayush_data|not_null          |hhsize     |                  |null                                               |2025-01-06 21:40:05.216 +0530|2025-01-06 21:40:05.216 +0530|Bhargav Kowshik|
Screenshot 2025-01-06 at 9 44 14 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adedekris adedekris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix 'last_updated_by' showing incorrect data for newly created tests"
2 participants
@bkowshik @adedekris