Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DF] Add TypeCoercion optimizer rule #723

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

andygrove
Copy link
Contributor

@andygrove andygrove commented Aug 25, 2022

I am working on adding this rule to DataFusion (see apache/datafusion#3222 and apache/datafusion#3254), but we may as well add it directly to the project for now so we can iterate faster on the rules.

@andygrove
Copy link
Contributor Author

@charlesbluca fyi

Copy link
Collaborator

@jdye64 jdye64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is 100% awesome! Had already reviewed in DataFusion. Think it makes complete sense to iterate on it here for a bit and then can back it out once it is finalized in DataFusion. We have done that several times already anyway.

@jdye64 jdye64 merged commit 6c4c5d3 into dask-contrib:datafusion-sql-planner Aug 25, 2022
@andygrove andygrove deleted the type-coercion branch August 25, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants