From 509cec4437c758587db80ec306a7101eaee763c0 Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Wed, 15 Jan 2025 11:18:59 -0800 Subject: [PATCH 1/2] fix the deploy_pages.yaml workflow --- .github/workflows/deploy_pages.yaml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/deploy_pages.yaml b/.github/workflows/deploy_pages.yaml index e0c2034b2..7d89b92dd 100644 --- a/.github/workflows/deploy_pages.yaml +++ b/.github/workflows/deploy_pages.yaml @@ -9,6 +9,13 @@ on: paths: - '.github/workflows/deploy_pages.yaml' - 'pkgs/markdown/**' + # TODO(devoncarew): remove! used for testing the deploy PR + pull_request: + branches: [ main ] + paths: + - '.github/workflows/deploy_pages.yaml' + - 'pkgs/markdown/**' + # TODO(devoncarew): remove! used for testing the deploy PR jobs: deploy: @@ -34,7 +41,7 @@ jobs: dart compile js -o example/app.dart.js --minify --no-frequency-based-minification --no-source-maps example/app.dart - working-directory: pkgs/markdown/example + working-directory: pkgs/markdown # Create the _site directory. - run: mkdir _site From cdbd7541774ea47dfb7677e60d12ef066dd58472 Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Wed, 15 Jan 2025 11:23:42 -0800 Subject: [PATCH 2/2] remove todos --- .github/workflows/deploy_pages.yaml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/deploy_pages.yaml b/.github/workflows/deploy_pages.yaml index 7d89b92dd..879c57f04 100644 --- a/.github/workflows/deploy_pages.yaml +++ b/.github/workflows/deploy_pages.yaml @@ -9,13 +9,6 @@ on: paths: - '.github/workflows/deploy_pages.yaml' - 'pkgs/markdown/**' - # TODO(devoncarew): remove! used for testing the deploy PR - pull_request: - branches: [ main ] - paths: - - '.github/workflows/deploy_pages.yaml' - - 'pkgs/markdown/**' - # TODO(devoncarew): remove! used for testing the deploy PR jobs: deploy: