Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2024-0384: error[unmaintained]: instant is unmaintained #363

Open
stevenj opened this issue Jan 2, 2025 · 1 comment
Open

RUSTSEC-2024-0384: error[unmaintained]: instant is unmaintained #363

stevenj opened this issue Jan 2, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@stevenj
Copy link

stevenj commented Jan 2, 2025

Describe the bug

cargo-deny is complaining about unmaintained crates used by rust-ipfs v0.14.1

error[unmaintained]: `instant` is unmaintained
    ┌─ /home/.../Cargo.lock:254:1
    │
254 │ instant 0.1.13 registry+https://github.com/rust-lang/crates.io-index
    │ -------------------------------------------------------------------- unmaintained advisory detected
    │
    = ID: RUSTSEC-2024-0384
    = Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0384
    = This crate is no longer maintained, and the author recommends using the maintained [`web-time`] crate instead.

      [`web-time`]: https://crates.io/crates/web-time
    = Solution: No safe upgrade is available!
    = instant v0.1.13
      ├── futures-ticker v0.0.3
      │   └── libp2p-gossipsub v0.47.0
      │       └── libp2p v0.54.1
      │           ├── libp2p-relay-manager v0.3.1
      │           │   └── rust-ipfs v0.14.1
      │           │       └── ...
      │           └── rust-ipfs v0.14.1 (*)
      └── rust-ipfs v0.14.1 (*)
@stevenj stevenj added the bug Something isn't working label Jan 2, 2025
@dariusc93
Copy link
Owner

dariusc93 commented Jan 2, 2025

Thanks for the report. Indeed instant is unmaintained and should not be used, however, it is currently used here under wasm32-unknown-unknown target as a feature due one of the dependencies used upstream in libp2p still relying on it and was overlooked in libp2p/rust-libp2p#5347. It is corrected upstream in libp2p/rust-libp2p#5674 and only awaiting a release upstream before updating it here :)

EDIT: We can leave this open until it is released upstream and will close it once we update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants