Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent dapr.yaml and appIDs #1152

Open
wants to merge 7 commits into
base: release-1.15
Choose a base branch
from

Conversation

marcduiker
Copy link
Contributor

@marcduiker marcduiker commented Jan 29, 2025

Description

  1. All dapr.yaml files now start with the appID as the first key in the apps array.
  2. appIDs are consistent across languages and APIs. This includes http and sdk variations and workflow appIDs.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1151

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
Copy link

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marc, we should check that this works after Elena's PR: #1148

jobs/go/http/dapr.yaml Outdated Show resolved Hide resolved
Signed-off-by: Marc Duiker <[email protected]>
@alicejgibbons
Copy link

@marcduiker you need to change merge target into release-1.15 branch too btw

@marcduiker marcduiker changed the base branch from master to release-1.15 January 31, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent usage of multi-app run file definitions
2 participants