Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier Output #41

Open
soheilrahsaz opened this issue Aug 17, 2021 · 3 comments
Open

Prettier Output #41

soheilrahsaz opened this issue Aug 17, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@soheilrahsaz
Copy link

Hello
Again Thank you for this code and your quick replies and fixes.
After showing the result to the end-user, I received some suggestions just to make the output video look prettier to the end-user eyes:
1- Adding some margin from top-right-bottom-left. (especially for the chat part)
2- Adding some sort of separation lines to distinguish between whiteboard and chat
image

@danielpetri1 danielpetri1 added the enhancement New feature or request label Aug 17, 2021
@danielpetri1
Copy link
Owner

danielpetri1 commented Aug 31, 2021

Hi, thanks for the suggestion.
Unfortunately I won't have the time to work on visual enhancements, since the focus is currently on the functionality.
You could replace the white background with a still image having the delineators to obtain the separation lines.
This is easily done in FFmpeg:

ffmpeg -framerate 24 -loop 1 -i path/to/image/with/lines...

Nonetheless, PRs are more than welcome.

Regards
Daniel

@gschwed
Copy link

gschwed commented Sep 1, 2021

Hi @danielpetri1 and @soheilrahsaz ,
I fully vote for that changes in the layout.

What has to be done to include the lines?
What can we do to help?

@soheilrahsaz
Copy link
Author

Hello @gschwed
Unfortunately, I don't know Ruby. So It takes a bit longer for me to actually figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants