From 27d90ef5051c20e6c96788cf89dcb75b713abe7f Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Tue, 23 Apr 2024 21:46:48 -0400 Subject: [PATCH 1/3] Explicitly specify macos-14 (non arm64) to avoid making macos-latest to point to arm one That one lacks pythons 3.8 and 3.9 --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 2a55ddc4..c33bb4b3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -18,7 +18,7 @@ jobs: os: - windows-2019 - ubuntu-latest - - macos-latest + - macos-14 python: - 3.8 - 3.9 From b3281b2f3c5f521c204baf1b00cbf6721341b4dc Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Tue, 23 Apr 2024 21:54:10 -0400 Subject: [PATCH 2/3] Use macos-12 for testing where we sweep through python 3.8 and 3.9 --- .github/workflows/test-nonetwork.yml | 2 +- .github/workflows/test.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-nonetwork.yml b/.github/workflows/test-nonetwork.yml index ad846400..9c50916d 100644 --- a/.github/workflows/test-nonetwork.yml +++ b/.github/workflows/test-nonetwork.yml @@ -17,7 +17,7 @@ jobs: os: - windows-2019 - ubuntu-latest - - macos-latest + - macos-12 python: - 3.8 - 3.9 diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c33bb4b3..fcc744f4 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -18,7 +18,7 @@ jobs: os: - windows-2019 - ubuntu-latest - - macos-14 + - macos-12 python: - 3.8 - 3.9 From 1ad60239fb62e9dce37569b9926d17603703167d Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Tue, 23 Apr 2024 21:55:28 -0400 Subject: [PATCH 3/3] Switch to test using python 3.11 for dandi-cli MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Primary motivator is that macos-latest swiched to arm64 and does not have support for python 3.8 and 3.9 . Comment in the CI says to match version used by dandi-api for some reason. There we use 3.11 ATM: ❯ git grep '\<3\.' -- .github/workflows/ .github/workflows/backend-ci.yml: python-version: "3.11" .github/workflows/cli-integration.yml: - "3.11" .github/workflows/frontend-ci.yml: python-version: '3.11' .github/workflows/frontend-ci.yml: python-version: '3.11' ❯ git describe v0.3.83 --- .github/workflows/test-dandi-cli.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-dandi-cli.yml b/.github/workflows/test-dandi-cli.yml index 416059f2..98cfc82f 100644 --- a/.github/workflows/test-dandi-cli.yml +++ b/.github/workflows/test-dandi-cli.yml @@ -25,10 +25,10 @@ jobs: python: # Use the only Python which is ATM also used by dandi-api # - 3.7 - - 3.8 + # - 3.8 # - 3.9 # - '3.10' - # - '3.11' + - '3.11' version: - master - release