-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace issues #24
Comments
Thanks for the inputs, yes, the gem has room of improvement, will put this on the backlog and try to tackle these tasks when I will have some spare time |
I can gladly put together a PR next week. Unless you want to tackle that one yourself? |
if you have time would be superb! |
I do. Will tackle this after finishing #23. The ruby class namespace changes will not be backwards compatible though. So this could be a good chance for a major release and to remove the png code that touches the filesystem. What do you think? |
good point, I would maybe wait a bit until we regroup some others breaking changes before releasing v2 of the gem |
Agreed. I'll create a first PR just for the CSS namespacing as those can be backwards compatible. |
Hey @damoiser during working on #23 I noticed two namespacing issues I would like to address:
QRBills
module. E.g.QRGenerator
becomesQRBills::QRGenerator
and so forth..subtitle
becomes.qrbills__subtitle
.qrbills__
could be changed to whatever the developer wishes.The text was updated successfully, but these errors were encountered: