From f90208660c94e3c233ce127ebade0c59679f18ce Mon Sep 17 00:00:00 2001 From: Colton Padden Date: Thu, 23 Jan 2025 14:11:58 -0500 Subject: [PATCH 1/5] [docs] handle multi-redirects for dagster plus --- docs/docs-beta/vercel.json | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/docs/docs-beta/vercel.json b/docs/docs-beta/vercel.json index 7c6a2bd7aeb30..75ff420e7a00a 100644 --- a/docs/docs-beta/vercel.json +++ b/docs/docs-beta/vercel.json @@ -361,17 +361,12 @@ "permanent": false }, { - "source": "/dagster-cloud", - "destination": "/dagster-plus/", - "permanent": false - }, - { - "source": "/dagster-cloud/managing-deployments/setting-up-alerts", + "source": "/dagster-plus/managing-deployments/setting-up-alerts", "destination": "/dagster-plus/features/alerts/", "permanent": false }, { - "source": "/dagster-cloud/managing-deployments/dagster-cloud-cli", + "source": "/dagster-plus/managing-deployments/dagster-cloud-cli", "destination": "/dagster-plus/deployment/management/dagster-cloud-cli/", "permanent": false }, From 1b9714240918513a3636f89886dba6213e5d36b0 Mon Sep 17 00:00:00 2001 From: Colton Padden Date: Thu, 23 Jan 2025 14:18:16 -0500 Subject: [PATCH 2/5] wip --- docs/docs-beta/vercel.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/docs-beta/vercel.json b/docs/docs-beta/vercel.json index 75ff420e7a00a..0d96ddd67ae27 100644 --- a/docs/docs-beta/vercel.json +++ b/docs/docs-beta/vercel.json @@ -371,7 +371,7 @@ "permanent": false }, { - "source": "/dagster-cloud/developing-testing/code-locations", + "source": "/dagster-plus/developing-testing/code-locations", "destination": "/dagster-plus/deployment/code-locations/", "permanent": false }, From 987e3d26a64836e3aa76596924fe6448be2ca917 Mon Sep 17 00:00:00 2001 From: Colton Padden Date: Thu, 23 Jan 2025 14:46:25 -0500 Subject: [PATCH 3/5] prevent deployment to legacy docs --- .github/workflows/build-docs.yml | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build-docs.yml b/.github/workflows/build-docs.yml index 380d7f3e6da40..dc72aca956dd5 100644 --- a/.github/workflows/build-docs.yml +++ b/.github/workflows/build-docs.yml @@ -2,22 +2,23 @@ name: Deploy Docs on: push: branches: - - master - - "release-*" # older verions of the docs - - docs-prod # prod - paths: - - docs/** - - "!docs/docs-beta/**" # Exclude docs-beta - - examples/docs_snippets/** - - CHANGES.md - - .github/workflows/build-docs.yml - pull_request: + # - master + # - "release-*" # older verions of the docs + # - docs-prod # prod + - "legacy-docs-release-*" # older verions of the docs paths: - docs/** - "!docs/docs-beta/**" # Exclude docs-beta - examples/docs_snippets/** - CHANGES.md - .github/workflows/build-docs.yml + # pull_request: + # paths: + # - docs/** + # - "!docs/docs-beta/**" # Exclude docs-beta + # - examples/docs_snippets/** + # - CHANGES.md + # - .github/workflows/build-docs.yml concurrency: # Cancel in-progress runs on same branch group: ${{ github.workflow}}-${{github.ref}} From 5152b5fc601151a1c9cb872ec679b932095d152f Mon Sep 17 00:00:00 2001 From: Colton Padden Date: Thu, 23 Jan 2025 14:46:53 -0500 Subject: [PATCH 4/5] update banner --- docs/docs-beta/docusaurus.config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/docs-beta/docusaurus.config.ts b/docs/docs-beta/docusaurus.config.ts index 349b8d684d20a..f01616d1c6ced 100644 --- a/docs/docs-beta/docusaurus.config.ts +++ b/docs/docs-beta/docusaurus.config.ts @@ -41,7 +41,7 @@ const config: Config = { }, announcementBar: { id: 'announcementBar', - content: `

Welcome to Dagster's new and improved documentation site!

You can find the legacy documentation with content for versions 1.9.8 and earlier at legacy-docs.dagster.io.
`, + content: `

Welcome to Dagster's new and improved documentation site!

You can find the legacy documentation with content for versions 1.9.9 and earlier at legacy-docs.dagster.io.
`, }, colorMode: { defaultMode: 'light', From f431709d85d0dba642153c7ec7c6d78f68dde024 Mon Sep 17 00:00:00 2001 From: Colton Padden Date: Thu, 23 Jan 2025 14:47:56 -0500 Subject: [PATCH 5/5] hide feedback --- docs/docs-beta/docusaurus.config.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/docs-beta/docusaurus.config.ts b/docs/docs-beta/docusaurus.config.ts index f01616d1c6ced..b522d05076857 100644 --- a/docs/docs-beta/docusaurus.config.ts +++ b/docs/docs-beta/docusaurus.config.ts @@ -112,12 +112,12 @@ const config: Config = { // docId: 'changelog', // position: 'right', //}, - { - label: 'Feedback', - href: 'https://github.com/dagster-io/dagster/discussions/24816', - position: 'right', - className: 'feedback-nav-link', - }, + // { + // label: 'Feedback', + // href: 'https://github.com/dagster-io/dagster/discussions/24816', + // position: 'right', + // className: 'feedback-nav-link', + // }, ], }, image: 'img/docusaurus-social-card.jpg',