Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unexpected colors for stitches #159

Closed
MAETempels opened this issue Oct 6, 2020 · 3 comments
Closed

unexpected colors for stitches #159

MAETempels opened this issue Oct 6, 2020 · 3 comments
Assignees
@jo-pol
Labels
bug high priority scala-js This implies installing sbt and executing one of the toJS scripts. http://www.scala-js.org/

Comments

@MAETempels
Copy link
Collaborator

When I use stitchdefinition Tctc, the color of the stich becomes orange/brown.
When I use ctC or cCt it turns green. Cctt: brown

image

The generated thread diagram is oké.
@jo-pol
Copy link
Collaborator

jo-pol commented Nov 4, 2020

See also #49

@jo-pol jo-pol added medium priority scala-js This implies installing sbt and executing one of the toJS scripts. http://www.scala-js.org/ labels Nov 4, 2020
@jo-pol jo-pol mentioned this issue Nov 4, 2020
Closed
@jo-pol jo-pol added the bug label Nov 4, 2020
@jo-pol
Copy link
Collaborator

jo-pol commented Nov 22, 2020 •
edited
Loading

related issue, ctctpctct

The strategy should have been to ignore unknown characters. The dot could be used as an intended pin that is not drawn as pins are rarely place properly.

image

@jo-pol jo-pol self-assigned this Nov 25, 2020
@jo-pol
Copy link
Collaborator

jo-pol commented Jan 1, 2025

With the new color code this issue no longer applies.

@jo-pol jo-pol closed this as completed Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jo-pol jo-pol

Labels
bug high priority scala-js This implies installing sbt and executing one of the toJS scripts. http://www.scala-js.org/
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jo-pol @MAETempels