From 3a5d94dfcef11db077a81f258382f569c3299c4b Mon Sep 17 00:00:00 2001 From: Max Franz Date: Tue, 18 Jun 2024 10:54:53 -0400 Subject: [PATCH] Ignore other mouse buttons during a left button gesture Ref: "free" event doesn't fire if you right click during drag and drop #3005 --- src/extensions/renderer/base/load-listeners.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/extensions/renderer/base/load-listeners.js b/src/extensions/renderer/base/load-listeners.js index d00155f0c4..66a9acf641 100644 --- a/src/extensions/renderer/base/load-listeners.js +++ b/src/extensions/renderer/base/load-listeners.js @@ -398,6 +398,11 @@ BRp.load = function(){ r.registerBinding( r.container, 'mousedown', function mousedownHandler( e ){ if( !eventInContainer(e) ){ return; } + // during left mouse button gestures, ignore other buttons + if (r.hoverData.which === 1 && e.which !== 1) { + return; + } + e.preventDefault(); blurActiveDomElement(); @@ -833,6 +838,11 @@ BRp.load = function(){ let clickTimeout, didDoubleClick, prevClickTimeStamp; r.registerBinding( containerWindow, 'mouseup', function mouseupHandler( e ){ // eslint-disable-line no-undef + // during left mouse button gestures, ignore other buttons + if (r.hoverData.which === 1 && e.which !== 1 && r.hoverData.capture) { + return; + } + var capture = r.hoverData.capture; if( !capture ){ return; } r.hoverData.capture = false;