Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast: GraphQL timeout error for many namespaces #6333

Closed
ColemanTom opened this issue Aug 28, 2024 · 5 comments
Closed

Broadcast: GraphQL timeout error for many namespaces #6333

ColemanTom opened this issue Aug 28, 2024 · 5 comments
Labels
bug Something is wrong :(

Comments

@ColemanTom
Copy link
Contributor

ColemanTom commented Aug 28, 2024

Description

I'm not sure if this is related to #6222, but, via the WUI, I did a broadcast to many namespaces and got this time out error from GraphQL.

2024-08-28T06:00:29Z INFO - Command "broadcast" received from USERNAME.
    broadcast(cycle_points=['*'], mode=put_broadcast, namespaces=['task_000', 'task_012', 'task_024', 'task_048', 'task_060', 'task_072', 'task_084', 'task_096', 'task_108', 'task_120', 'task_132', 'task_144', 'task_156', 'task_168', 'task_180', 'task_192', 'task_204', 'task_216', 'task_228', 'task_240'], settings=[{'execution time limt': 'PT30M'}])
Traceback (most recent call last):
  File "miniconda3/cylc-8.3.3/lib/python3.11/site-packages/promise/promise.py", line 844, in handle_future_result
    resolve(future.result())
            ^^^^^^^^^^^^^^^
  File "miniconda3/cylc-8.3.3/lib/python3.11/site-packages/cylc/flow/network/graphql.py", line 433, in async_resolve
    return await next_(root, info, **args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "miniconda3/cylc-8.3.3/lib/python3.11/site-packages/promise/iterate_promise.py", line 10, in iterate_promise
    yield from promise.future  # type: ignore
    ^^^^^^^^^^^^^^^^^^^^^^^^^
graphql.error.located_error.GraphQLLocatedError: execution time limt

Reproducible Example

Will see if I can provide a simple one, but none provided yet. Just broadcast to many tasks at once. I've not been able to replicate it from CLI.

Expected Behaviour

No error, broadcasts get through. Maybe you need to split the broadcast up into chunks of N size?

@oliver-sanders
Copy link
Member

@ColemanTom, I haven't been able to replicate this one. Where did you observe this traceback, in the scheduler log or the Cylc UI Server log?

It's quite likely that this is related to #6334 given the execution time limit key. Might be worth trying to reproduce it with the fix for that issue if possible.

@oliver-sanders oliver-sanders added this to the 8.3.x milestone Aug 28, 2024
@ColemanTom
Copy link
Contributor Author

Cylc log. I don't even know where the ui log is to look at that.

@oliver-sanders
Copy link
Member

~/.cylc/uiserver/log

@ColemanTom
Copy link
Contributor Author

It could simply be a slow network caused it. I was running things through the WUI for another user too if that adds any latency, it wasn't as myself. I'll see if I can do it again as myself and as a different user again later or next week.

@oliver-sanders oliver-sanders added needs reproducing A bug report that does not yet have a reproducible example and removed investigation labels Sep 26, 2024
@oliver-sanders oliver-sanders removed the needs reproducing A bug report that does not yet have a reproducible example label Oct 17, 2024
@oliver-sanders
Copy link
Member

Aah, I've just spotted what's going on here. It's a typo limt rather than "limit".

graphql.error.located_error.GraphQLLocatedError: execution time limt

It is erroring because the config broadcasted is invalid, however, the error isn't being caught and logged nicely.

Have opened an issue to cover this: #6429

@oliver-sanders oliver-sanders removed this from the 8.3.x milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

No branches or pull requests

3 participants
@ColemanTom @oliver-sanders and others