-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip Mode #755
Skip Mode #755
Conversation
3af57b8
to
736d010
Compare
6c8ba68
to
c4cd253
Compare
Please could you update the advice for family-family triggering to make use of skip mode. Worth skimming the docs to see if we document any other dummy task use cases anywhere. |
Good call: I've realized responding to Ronnie's comments that we've somewhat overloaded the term dummy to mean
I've tried to remove either of the second two use cases for the word dummy. I also found two references to "dummy-local" mode which hasn't been a thing for at least 3 years (I deleted it). |
Repeating my comment from the cylc-flow PR:
|
1f56820
to
4d9f535
Compare
I've tried to respond to comments from @MetRonnie and @hjoliver (if you're both saying the same thing I'll run with it). After a certain amount of thought I've restored the references to dummy tasks and added some disambiguation in the glossary. I've also renamed the two main files to reflect the difference between workflow and task run modes. To this end 4d9f535 contains actual changes, whilst 7408002 is just the file renaming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now, generally, just a bunch of minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I like your glossary entry on "dummy task".
91f27a9
to
4f643b6
Compare
494f040
to
faeca94
Compare
6749dd5
to
bdf9015
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with fixes.
Add details of skip mode move workflow run modes description back to simulation-modes.rst change simulation-modes to workflow-run-modes Update src/user-guide/running-workflows/workflow-run-modes.rst Co-authored-by: Hilary James Oliver <[email protected]> Update src/glossary.rst Co-authored-by: Ronnie Dutta <[email protected]> Update src/user-guide/task-implementation/task-run-modes.rst rename task-run-modes.rst → skip-mode.rst Update src/user-guide/interventions/index.rst Co-authored-by: Oliver Sanders <[email protected]> fix squiffy title levels Update src/user-guide/task-implementation/skip-mode.rst Co-authored-by: Oliver Sanders <[email protected]> simplify config links by setting doc to approprate scop fix directives
4f5b0a6
to
ea416dd
Compare
Companion of cylc/cylc-flow#6039
Closes #783
Closes #784
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.