New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About Triplane Warping #3

Open

ljnhahaha opened this issue Oct 21, 2024 · 0 comments

ljnhahaha commented Oct 21, 2024

Hi, thanks for releasing the code, but I have a question about the code of triplane warping in gen_warped_images.py:

 planes[:,0,:,:,:] = warper(planes[:,0,:,:,:], ldks_src_3d[:,:,[0,1]], ldks_tgt_3d[:,:,[0,1]])
 planes[:,2,:,:,:] = warper(planes[:,2,:,:,:], ldks_src_3d[:,:,[0,2]], ldks_tgt_3d[:,:,[0,2]])
 planes[:,1,:,:,:] = warper(planes[:,1,:,:,:], ldks_src_3d[:,:,[2,1]], ldks_tgt_3d[:,:,[2,1]])

I think it should be

 planes[:,0,:,:,:] = warper(planes[:,0,:,:,:], ldks_src_3d[:,:,[0,1]], ldks_tgt_3d[:,:,[0,1]])
 planes[:,2,:,:,:] = warper(planes[:,2,:,:,:], ldks_src_3d[:,:,[2,0]], ldks_tgt_3d[:,:,[2,0]])
 planes[:,1,:,:,:] = warper(planes[:,1,:,:,:], ldks_src_3d[:,:,[0,2]], ldks_tgt_3d[:,:,[0,2]])

according to the projection matrix (it is a mistake in official repo)
Am I thinking something wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment