Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were three "issues" with the text in the sidebar of fuelcycle.org:
This PR addresses the first two bullet points (obvious issues), but leaves the third issue (more of a design choice) for later if others agree that this looks weird.
The CSS that defines the behavior of these elements is mostly found in a file called
cloud.css
, which I think does not exist in the website folder anywhere, and instead gets imported from somewhere else. Thus, to fix these issues, I simply overwrote the rules thatcloud.css
sets out inside thecyclus.css_t
file. Specifically, I modified:to
to remove the spaces between words (
cloud.css
had left/right margin and padding on those elements)and added:
to override the little yellow highlight box that exists in the :hover behavior. It seemed simplest for me to just get rid of the box rather than mess with making the box look nice, since that would require adding more padding back in which would make a weird space. The new look simply changes the color of the link on :hover to be the same yellow it was before, but without drawing the box (or more specifically, drawing a transparent box).
It's worth noting that, in general, using !important is bad practice unless it's really necessary, however since the specificity of the css rules for those boxes in
cloud.css
was really high, and these rules are unlikely to be used elsewhere I felt it was okay to use !important here.Another note: I'm pretty sure that you can get away with
margin: 0;
, but that hurts my brain (I like to see each one because it's a LOT more readable in my opinion). You cannot, however, get rid of the 0's in thepadding: 1px 0 3px 0;
block so far as I know.Final note: The formatting on "Cyclus" vs "CYCLUS" is a little inconsistent. I deleted the span which made "Cyclus" all caps because that line was REALLY long already, and earlier in the sidebar it appears as "Cyclus" but it would be easy enough to add it back if you wanted
Closes #403