Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh page with location fragment markers flash then disappear #4

Open
si-the-pie opened this issue Jun 11, 2020 · 0 comments
Open
Labels
bug Something isn't working

Comments

@si-the-pie
Copy link
Member

No markers appear when URL contains location fragment

wmp_no_markers

No markers appeared on this visit to:
https://www.widenmypath.com/suggest/#12/51.4845/-0.1624 but they do appear once the map is dragged. (Try opening that link in a new incognito window.)

To reproduce:

  1. Chrome > New Incognito Window

  2. Open the Inspect window, select Network and filter for photomap

  3. Paste https://www.widenmypath.com/suggest/#12/51.4845/-0.1624 into the incognito window and watch what happens

  4. Page appears opened on London area. Sometimes the markers appear in a flash and then moments later they disappear, sometimes they don't appear at all.

  5. Network log shows two calls to https://api.cyclestreets.net/v2/photomap.locations the first with a region covering the whole of the UK, the second covering the London area. These calls are issued at 1.22s and 1.33s. The first takes 600ms to respond, and the second 500ms.

  6. The markers do appear when the map is dragged, and from then on it seems fine.

Also tried in Safari and Firefox with similar outcomes, although it does work sometimes.

I'm guessing at what might be the cause here, but maybe if a second call to the photomap API is performed before the first has responded then the result of the first call should be dropped.

@si-the-pie si-the-pie added the bug Something isn't working label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant