Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method::getExampleByType is broken (beyond repair?) #32

Open
pies opened this issue Oct 22, 2015 · 0 comments
Open

Method::getExampleByType is broken (beyond repair?) #32

pies opened this issue Oct 22, 2015 · 0 comments
Labels
bug

Comments

@pies
Copy link

pies commented Oct 22, 2015

  1. Method::getExampleByType uses $this->body which doesn't exist. It should use $this->bodyList instead.
  2. $this->bodyList contains BodyInterface elements, but unfortunately BodyInterface is rather limited, so it's impossible to check if it has an example without widening the interface.

Since the same thing can be achieved without using this helper method, I suggest this method is removed (or fixed).
@cybertk cybertk added the bug label Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pies @cybertk