Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added navbar scroll effect #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nitishsaini706
Copy link

Thankyou for your valuable contribution to the project. Please check below mentioned points -

fixes #33

What kind of change does this PR introduce ?

This pr adds scroll effect on navbar

Documentation updated ?

No

Checklist

  • [ Y] I have performed a self-review of my own code
  • [ Y I have commented my code, particularly in hard-to-understand areas
  • [ Y] I have made corresponding changes to the documentation
  • [ Y] My changes generate no new warnings
  • [ Y] I have added tests that prove my fix is effective or that my feature works
  • [ Y] New and existing unit tests pass locally with my changes
  • [ Y] Code is working on both device and system

Screenshots

navbar

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Curiomind, our mentors will review it soon. 🙌🏻

Comment on lines 8 to 46
.login:hover{
background-color: black;
color: white;
transition: all ease-in 0.4s;
}

/* @media (top:10vh) {

.navbar{
background-color: black;
}
} */

.navbar.active {
background-color: rgb(0, 0, 0);

}

.navbar.active a{
transition: all ease 0.3s;
color:white;
}

.navbar.active button{
transition: all ease-in 0.3s;

color: white;
}

.login:hover{
border: 0.5px white solid;
}

.nav-btn:hover
{
transform: scale(1.15);
background-size: 1100% ;
} No newline at end of file
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly choose a color which would match the existing color scheme of the application

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okk sure

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geekymeeky I find this color matching the theme of our website
Screenshot 2022-03-17 172345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll bar
2 participants