Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLElementTagNameMap declarations are duplicated in the published types. #352

Open
lgarron opened this issue Jan 5, 2025 · 0 comments
Open
Labels
🐞 bug Something isn't working 📦 cubing/twisty 🙋 help wanted Extra attention is needed

Comments

@lgarron
Copy link
Member

lgarron commented Jan 5, 2025

╭─── /Users/lgarron/Code/git/github.com/cubing/cubing.js ──────────────────────────────────────
├─  main  | ✔ 
├─ lgarron@Germain
│ make clean build-lib-types &> /dev/null && rg --max-columns 1000 HTMLElementTagNameMap ./dist
┴
./dist/lib/cubing/PuzzleLoader-BN2CTwbG.d.ts
2399:    interface HTMLElementTagNameMap {
2451:    interface HTMLElementTagNameMap {
2557:    interface HTMLElementTagNameMap {
2574:    interface HTMLElementTagNameMap {

./dist/lib/cubing/TwizzleLink.d-BzfMIk_O.d.ts
1192:    interface HTMLElementTagNameMap {
1244:    interface HTMLElementTagNameMap {
1350:    interface HTMLElementTagNameMap {
1367:    interface HTMLElementTagNameMap {
┬
╰─── ⏱️ 11.621s ───────────────────────────────────────────────────────────────────────────────

This breaks TypeScript checking for dependent packages unless they enabled "skipLibCheck": true (which is an inappropriate long-term workaround for this).

@lgarron lgarron changed the title HTMLElementTagNameMap is duplicated in the published types. HTMLElementTagNameMap declarations are duplicated in the published types. Jan 5, 2025
@lgarron lgarron added the 🐞 bug Something isn't working label Jan 5, 2025
@lgarron lgarron added 🙋 help wanted Extra attention is needed 📦 cubing/twisty labels Jan 6, 2025
lgarron added a commit to cubing/scramble-display that referenced this issue Jan 6, 2025
lgarron added a commit to cubing/scramble-display that referenced this issue Jan 6, 2025
lgarron added a commit to cubing/scramble-display that referenced this issue Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 📦 cubing/twisty 🙋 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant