Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate over all events providing all information available #213

Open
maxnoe opened this issue Oct 7, 2020 · 2 comments · May be fixed by #214
Open

Iterate over all events providing all information available #213

maxnoe opened this issue Oct 7, 2020 · 2 comments · May be fixed by #214

Comments

@maxnoe
Copy link
Member

maxnoe commented Oct 7, 2020

Adressing #212 , I think it would just be better to provide an iterator that yields all events, providing what information is available.

So a non triggered event would only contain mc_shower and mc_event (and possibly the photons) while a triggered event would additionally contain the telescope data / array trigger information.

Like this, the simulated events info could be generated in the same event loop as the normal analysis.

@vuillaut
Copy link
Member

vuillaut commented Oct 7, 2020

I like it.

@watsonjj
Copy link
Contributor

watsonjj commented Oct 8, 2020

Yes this would be perfect

@maxnoe maxnoe linked a pull request Oct 14, 2020 that will close this issue
@dneise dneise linked a pull request Oct 14, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants