Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep "true MC" info also for non-triggered events and telescopes #2391

Closed
moralejo opened this issue Aug 31, 2023 · 1 comment
Closed

Keep "true MC" info also for non-triggered events and telescopes #2391

moralejo opened this issue Aug 31, 2023 · 1 comment

Comments

@moralejo
Copy link
Contributor

I think that this:

if trigger.event_type == EventType.SUBARRAY:
shower = self._fill_simulated_event_information(array_event)
else:
shower = None

prevents that the event-wise MC information is filled for non-triggered events. That information is certainly useful for some tests (e.g. checking the fulfillment of some requirements).

Analogously, in triggered events, it seems that the true MC info, like the total number of p.e. from C-photons on the camera, or the pixel-wise number of p.e. from C-photons, is missing as well.

@moralejo
Copy link
Contributor Author

moralejo commented Aug 31, 2023

I am closing this, it is a known issue and discussed elsewhere (I mean the reading of all MC events can be done using pyeventio directly, no need to change it here):
cta-observatory/pyeventio#214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant