From 816c429bf86013e8398fe670bcd697c270f1c9d3 Mon Sep 17 00:00:00 2001 From: Thomas Vuillaume Date: Thu, 7 Apr 2022 00:27:13 +0200 Subject: [PATCH 1/2] Reduce size of random forests in standard config Based on https://indico.cta-observatory.org/event/3992/ and cross-check on real-data from @SeiyaNozaki showing no diff in Crab spectra between the two configs. --- lstchain/data/lstchain_standard_config.json | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lstchain/data/lstchain_standard_config.json b/lstchain/data/lstchain_standard_config.json index 39f4c35f74..9587c220b7 100644 --- a/lstchain/data/lstchain_standard_config.json +++ b/lstchain/data/lstchain_standard_config.json @@ -60,7 +60,7 @@ }, "random_forest_energy_regressor_args": { - "max_depth": 50, + "max_depth": 30, "min_samples_leaf": 2, "n_jobs": 4, "n_estimators": 150, @@ -69,7 +69,7 @@ "max_features": "auto", "max_leaf_nodes": null, "min_impurity_decrease": 0.0, - "min_samples_split": 2, + "min_samples_split": 10, "min_weight_fraction_leaf": 0.0, "oob_score": false, "random_state": 42, @@ -78,7 +78,7 @@ }, "random_forest_disp_regressor_args": { - "max_depth": 50, + "max_depth": 30, "min_samples_leaf": 2, "n_jobs": 4, "n_estimators": 150, @@ -87,7 +87,7 @@ "max_features": "auto", "max_leaf_nodes": null, "min_impurity_decrease": 0.0, - "min_samples_split": 2, + "min_samples_split": 10, "min_weight_fraction_leaf": 0.0, "oob_score": false, "random_state": 42, @@ -96,12 +96,12 @@ }, "random_forest_disp_classifier_args": { - "max_depth": 100, + "max_depth": 30, "min_samples_leaf": 2, "n_jobs": 4, "n_estimators": 100, "criterion": "gini", - "min_samples_split": 2, + "min_samples_split": 10, "min_weight_fraction_leaf": 0.0, "max_features": "auto", "max_leaf_nodes": null, @@ -115,12 +115,12 @@ }, "random_forest_particle_classifier_args": { - "max_depth": 100, + "max_depth": 30, "min_samples_leaf": 2, "n_jobs": 4, "n_estimators": 100, "criterion": "gini", - "min_samples_split": 2, + "min_samples_split": 10, "min_weight_fraction_leaf": 0.0, "max_features": "auto", "max_leaf_nodes": null, From b43470968a6f60bc211e9f7d4d7c4ef642563174 Mon Sep 17 00:00:00 2001 From: Chaitanya Priyadarshi Date: Tue, 12 Apr 2022 15:33:27 +0200 Subject: [PATCH 2/2] Fix test for energy-dependent IRFs --- lstchain/tools/tests/test_tools.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lstchain/tools/tests/test_tools.py b/lstchain/tools/tests/test_tools.py index d4bc7fee57..c717ed2d1c 100644 --- a/lstchain/tools/tests/test_tools.py +++ b/lstchain/tools/tests/test_tools.py @@ -139,7 +139,9 @@ def test_create_irf_point_like_energy_dependent_cuts( "--overwrite", "--energy-dependent-gh", "--point-like", - "--energy-dependent-theta" + "--energy-dependent-theta", + "--DL3Cuts.max_theta_cut=1", + "--DL3Cuts.fill_theta_cut=1" ], cwd=temp_dir_observed_files, )