You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.
Write benchmark_median and benchmark_minimum convenience functions. Update: this became median circ benchmark
The main issue left is that the loaded trace has a bunch of ReconstructedType, and we need to handle those. Either write a custom compare_benchmark(minimum, tr) that reruns the benchmarks, or have map use @ignore_errors. I'm leaning towards the latter. We might then write map(ratio, tr1, tr2). This will require writing ratio(tr1, tr2) = ratio(value(tr1), value(tr2)).
The text was updated successfully, but these errors were encountered:
This is mostly done, but I want to do something better about errors when reloading a saved benchmark. I'd like to remove them and warn, which is the best I can do.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
TODO:
benchmark_median
andbenchmark_minimum
convenience functions. Update: this becamemedian circ benchmark
The main issue left is that the loaded trace has a bunch of ReconstructedType, and we need to handle those. Either write a custom
compare_benchmark(minimum, tr)
that reruns the benchmarks, or havemap
use@ignore_errors
. I'm leaning towards the latter. We might then writemap(ratio, tr1, tr2)
. This will require writingratio(tr1, tr2) = ratio(value(tr1), value(tr2))
.The text was updated successfully, but these errors were encountered: