Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Support profiling comparisons #47

Open
cstjean opened this issue Sep 2, 2017 · 1 comment
Open

Support profiling comparisons #47

cstjean opened this issue Sep 2, 2017 · 1 comment

Comments

@cstjean
Copy link
Owner

cstjean commented Sep 2, 2017

TODO:

  • Write benchmark_median and benchmark_minimum convenience functions. Update: this became median circ benchmark

The main issue left is that the loaded trace has a bunch of ReconstructedType, and we need to handle those. Either write a custom compare_benchmark(minimum, tr) that reruns the benchmarks, or have map use @ignore_errors. I'm leaning towards the latter. We might then write map(ratio, tr1, tr2). This will require writing ratio(tr1, tr2) = ratio(value(tr1), value(tr2)).

@cstjean
Copy link
Owner Author

cstjean commented Sep 6, 2017

This is mostly done, but I want to do something better about errors when reloading a saved benchmark. I'd like to remove them and warn, which is the best I can do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant