-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classification of Emitter in EnergySystem module #137
Comments
Thanks for picking up that idea! Is that somewhat the direction you were thinking of? What are your opinions? Others from the Energy Systems group? I'm not sure if I got all implications of that radical change in the structure. |
This flexibility is the structure might greatly support modelling of complex energy systems, e.g. industrial applications as by @kwakuwulf |
Hi! One comment: from your proposal, the FinalEnergy class is be moved to _EnergySystem, as it is common to all subclasses. |
And it could be even simplier by connecting different |
Hi Moritz, Giorgio,
|
|
@mlauster Other point: Decentralised HVAC systems (electrical radiators, split unit) all transform final energy to used energy, however I would consider them as ConversionSystem rather than Emitters... Looking quickly in the BEDES data specification from DOE in USA (https://bedes.lbl.gov/bedes-online/), they separated "Heating" and "Heating Delivery (radiator, air handler, fan coil, micro heat pump etc...). Moreover, they have also a "Air Distribution" that we haven't considered until now (maybe rather in Occupancy/Facility Anyway, all this should be discussed together, as well as with participants of Occupancy module like @jaykae26, if possible face to face (otherwise by telco)... |
@RomainNouvel, you are right, that's a difficult distinguishment. The existing definition is fine for me, as long as the occupancy module allows all specifications we need. E.g. @kwakuwulf had once the question, if we can model heat recovery from lighting systems in shops. There you would need to have |
Proposed common attributes of _EnergySystem:
|
In order to support the doscussion of a new Energy Systemj module, I tried to generate an UML model besed on the actual state of discussion. Please let me know whether I understoof everything correctly. |
I vote for that! Thanks, @JoachimBenner for putting that into a structure! I didn't check your proposal in detail so far (and if all elements of the old version have been transferred), but it looks good from what I could assess! |
Hi Joachim, I have a problem with the relation between EnergyDemand and _EnergySystem (at least wording). If _EnergySystem is not an EnergyConversaionSystem, the name of the present relation "consumes / isconsumedby" does not fit. |
For me, the distinction between TotalEnergy and EnergyDamand is not really clear. What are the exact definitions of these two FeatureTypes? I understand that TotalEnergy is that amount of energy that is stored in a specific _StorageSystem, emitted by an Emitter, distributed with an EnergyDistributionSystem or converted by an EnergyConversionSystem. What is, in contrast to this, the EnergyDemand of these components? At the moment, the relation to EnergyDemand is defined in the super class _EnergySystem. Is this appropriate, or do we need specific relations in the derived classes? |
@JoachimBenner from my site this already looks good and much more straight forward as Concerning I also have another remark to your new UML. In previous versions the feature |
Do you mean FinalEnergy and EnergyDemand?
However, with this definition, we see that we don't cover all forms of energy, for instance the heat produced by a thermal solar panels, or the heat stored in a tank, or the electricity produced by a CHP (which are neither EnergyDemand nor FinalEnergy). |
|
In that case the relation |
I agree that relations between EnergyDemand and _CityObject are missing. Up to version 0.8.0, there was only a unilateral relation: _CityObject --> EnergyDemand. In the new proposal, I modelled a bilateral relation, what do you think about this? I furthermore agree that the relation names consumes / isConsumedBy are not optimal. Taking Romains proposal, I changed them to provides / isProvidedBy. |
@RomainNouvel, if I got you correct, you would like to rename |
|
Ok, @RomainNouvel, that makes sense. Although, in a technical sense, |
In a first attempt to reorganise hierarchically most of the entities in the Energy System module, the classification of Emitter is somehow unclear. We have so far three "big families" of classes: Conversion, Storage and Distribution. The emitter is however alone and only connected to a Distribution class.
I was wondering, together with Joachim and Romain, whether there could be a way to characterise it a bit better. On one side, it is delivering energy to satisfy an energy demand, but it is not connected to it. On the other side, is it really a device which distributes energy (e.g. heat?), or just the end node of a distribution system?
The general idea is to define a general abstract class _EnergySystem which generalises all Conversion, Distribution and Storage Systems. An UML diagramme, and a new ticket, will be ready issued soon (thx Joachim!).
Dear members of the Energy System team, could you please help?
Thank you for your help!
g
The text was updated successfully, but these errors were encountered: